Improve error location at eof in LitStr::parse #1590

dtolnay · 2024-02-16T00:37:59Z

I noticed this in colin-kiegel/rust-derive-builder#310. When using litstr.parse() on a string literal token whose contents are empty, there previously were not any tokens in which the span could be transferred to the inner parser. This is what the "scope" span is supposed to be for, which is also used for parsing the contents of empty delimiters, for the same reason.

Before:

error: unexpected end of input, expected expression
 --> tests/compile-fail/deny_empty_default.rs:6:10
  |
6 | #[derive(Builder)]
  |          ^^^^^^^
  |
  = note: this error originates in the derive macro `Builder` (in Nightly builds, run with -Z macro-backtrace for more info)

After:

error: unexpected end of input, expected expression
 --> tests/compile-fail/deny_empty_default.rs:8:25
  |
8 |     #[builder(default = "")]
  |                         ^^

Improve error location at eof in LitStr::parse

51298d4

dtolnay force-pushed the streof branch from adee7a9 to 51298d4 Compare February 16, 2024 00:42

dtolnay merged commit 981359c into master Feb 16, 2024
28 checks passed

dtolnay deleted the streof branch February 16, 2024 00:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error location at eof in LitStr::parse #1590

Improve error location at eof in LitStr::parse #1590

dtolnay commented Feb 16, 2024

Improve error location at eof in LitStr::parse #1590

Improve error location at eof in LitStr::parse #1590

Conversation

dtolnay commented Feb 16, 2024